[Git-commits] [grml/grml-live] 5a1c60: GHA: setup shellcheck

Chris Hofstaedtler noreply at github.com
Tue Nov 26 18:04:05 CET 2024


  Branch: refs/heads/shellcheck
  Home:   https://github.com/grml/grml-live
  Commit: 5a1c6029bb39f8b0e0d04194ddf6d7e644702406
      https://github.com/grml/grml-live/commit/5a1c6029bb39f8b0e0d04194ddf6d7e644702406
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    A .github/workflows/pr-review.yml

  Log Message:
  -----------
  GHA: setup shellcheck


  Commit: 73755b341e90a9f2692a9e89b214c0419e3ea637
      https://github.com/grml/grml-live/commit/73755b341e90a9f2692a9e89b214c0419e3ea637
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix quoting issues


  Commit: 67742f32db735cf52b9be77da95c44647d4f9ba2
      https://github.com/grml/grml-live/commit/67742f32db735cf52b9be77da95c44647d4f9ba2
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: annotate NOCOLORS usage

Used by init-functions. Until we replace that, add this annotation.


  Commit: d11e6f1c0d4621f67e86d2981f63806d3c74a618
      https://github.com/grml/grml-live/commit/d11e6f1c0d4621f67e86d2981f63806d3c74a618
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: concat $@ correctly


  Commit: 267c4e21f1fb6608747a14d841f092ecd1a6ea0f
      https://github.com/grml/grml-live/commit/267c4e21f1fb6608747a14d841f092ecd1a6ea0f
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2166


  Commit: 9c0934d9339204379ec975be996b82e1372e89d6
      https://github.com/grml/grml-live/commit/9c0934d9339204379ec975be996b82e1372e89d6
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: ignore init-functions,lsb-functions sources


  Commit: 52fe72976e4cff120f8a1a7b90197396c5e31488
      https://github.com/grml/grml-live/commit/52fe72976e4cff120f8a1a7b90197396c5e31488
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: do not trap SIGKILL


  Commit: ed325d811699dc1d6b513a0970b62064d94aa2c8
      https://github.com/grml/grml-live/commit/ed325d811699dc1d6b513a0970b62064d94aa2c8
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: fix $? usage errors


  Commit: c081f7c5b31b4e559f5ecf3baec4dabd2be63e4a
      https://github.com/grml/grml-live/commit/c081f7c5b31b4e559f5ecf3baec4dabd2be63e4a
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: stop exporting SHORT_NAME

AFAICT nothing uses SHORT_NAME outside of grml-live itself.


  Commit: c5d27a102dc4d17dbcaacddcc49d42890db0a234
      https://github.com/grml/grml-live/commit/c5d27a102dc4d17dbcaacddcc49d42890db0a234
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2155

Declare and assign separately to avoid masking return values.


  Commit: 5da6885aa8d12b29c82d8b4b9ff3c40cd234036d
      https://github.com/grml/grml-live/commit/5da6885aa8d12b29c82d8b4b9ff3c40cd234036d
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2162

read without -r will mangle backslashes. Not relevant here.


  Commit: 07d1e7db9382a5d2937546d34a049d5cf0614ba8
      https://github.com/grml/grml-live/commit/07d1e7db9382a5d2937546d34a049d5cf0614ba8
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: PIPESTATUS is an array


  Commit: 1eefaa1bbdc75d26c37e86b280a562004f5fa97d
      https://github.com/grml/grml-live/commit/1eefaa1bbdc75d26c37e86b280a562004f5fa97d
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: ignore SC2164 in two places


  Commit: 5190aafa939cbf16f163409bfbb668fe5781a24f
      https://github.com/grml/grml-live/commit/5190aafa939cbf16f163409bfbb668fe5781a24f
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: use while/read instead of for find


  Commit: 72871a71aceffb85c9ead89bb87a96db42780bae
      https://github.com/grml/grml-live/commit/72871a71aceffb85c9ead89bb87a96db42780bae
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: remove dead extend_string_begin function


  Commit: dedf3e37ed1270dc05ffcf5b885879bd848a10e4
      https://github.com/grml/grml-live/commit/dedf3e37ed1270dc05ffcf5b885879bd848a10e4
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix one SC2010 case


  Commit: ef5cb767b2e08457a2ffdd30853930e9984fd32a
      https://github.com/grml/grml-live/commit/ef5cb767b2e08457a2ffdd30853930e9984fd32a
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: ignore SC2010 in two cases


  Commit: 2ae515186d875ba999b602986246714c847d1f54
      https://github.com/grml/grml-live/commit/2ae515186d875ba999b602986246714c847d1f54
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: rewrite extend_string_end without expr


  Commit: 777fb7b921d2b7e6ebf408b89a70ef20019c92b4
      https://github.com/grml/grml-live/commit/777fb7b921d2b7e6ebf408b89a70ef20019c92b4
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2004

$/${} is unnecessary on arithmetic variables.


  Commit: 6144aa0662a658c79f5fc6d50fc7f1983378b193
      https://github.com/grml/grml-live/commit/6144aa0662a658c79f5fc6d50fc7f1983378b193
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2018/SC2019


  Commit: c92e973a7311cd885abbec105eb69235b4c2b75d
      https://github.com/grml/grml-live/commit/c92e973a7311cd885abbec105eb69235b4c2b75d
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: write grmlmain.cfg in one go


  Commit: 593faf61834b041cfd101668e390308f4b8ea766
      https://github.com/grml/grml-live/commit/593faf61834b041cfd101668e390308f4b8ea766
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: turn off two info messages


  Commit: 6a3baec0d6263aa38b64464e2eed68321e5406b5
      https://github.com/grml/grml-live/commit/6a3baec0d6263aa38b64464e2eed68321e5406b5
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M scripts/generate_netboot_package.sh
    M scripts/release_helper.sh

  Log Message:
  -----------
  scripts: fix quoting issues found by shellcheck


  Commit: db8ad35f8d776e35028911787c34264641bd251b
      https://github.com/grml/grml-live/commit/db8ad35f8d776e35028911787c34264641bd251b
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M remaster/grml-live-remaster

  Log Message:
  -----------
  remaster: fix quoting issues found by shellcheck


  Commit: bb225fe0c3ad55833395aac3399def4a8cd3ff2e
      https://github.com/grml/grml-live/commit/bb225fe0c3ad55833395aac3399def4a8cd3ff2e
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M etc/grml/fai/config/hooks/instsoft.GRMLBASE
    M etc/grml/fai/config/hooks/instsoft.ZFS
    M etc/grml/fai/config/hooks/savelog.LAST.source
    M etc/grml/fai/config/hooks/updatebase.GRMLBASE

  Log Message:
  -----------
  fai hooks: fix shellcheck issues


  Commit: fe3eef989116df76230d9d593323ea2abb66fe31
      https://github.com/grml/grml-live/commit/fe3eef989116df76230d9d593323ea2abb66fe31
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M etc/grml/fai/config/scripts/DEBORPHAN/10-whitelist
    M etc/grml/fai/config/scripts/DEBORPHAN/98-clean-chroot
    M etc/grml/fai/config/scripts/GRMLBASE/01-packages
    M etc/grml/fai/config/scripts/GRMLBASE/02-run
    M etc/grml/fai/config/scripts/GRMLBASE/03-get-sources
    M etc/grml/fai/config/scripts/GRMLBASE/05-hostname
    M etc/grml/fai/config/scripts/GRMLBASE/15-initsetup
    M etc/grml/fai/config/scripts/GRMLBASE/16-depmod
    M etc/grml/fai/config/scripts/GRMLBASE/18-timesetup
    M etc/grml/fai/config/scripts/GRMLBASE/20-sudo
    M etc/grml/fai/config/scripts/GRMLBASE/21-usersetup
    M etc/grml/fai/config/scripts/GRMLBASE/25-locales
    M etc/grml/fai/config/scripts/GRMLBASE/30-fstab
    M etc/grml/fai/config/scripts/GRMLBASE/32-xorg
    M etc/grml/fai/config/scripts/GRMLBASE/33-aptsetup
    M etc/grml/fai/config/scripts/GRMLBASE/34-hosts
    M etc/grml/fai/config/scripts/GRMLBASE/38-udev
    M etc/grml/fai/config/scripts/GRMLBASE/39-modprobe
    M etc/grml/fai/config/scripts/GRMLBASE/45-grub-images
    M etc/grml/fai/config/scripts/GRMLBASE/46-grml-version
    M etc/grml/fai/config/scripts/GRMLBASE/47-update-wallpaper
    M etc/grml/fai/config/scripts/GRMLBASE/49-sshd
    M etc/grml/fai/config/scripts/GRMLBASE/50-lvm
    M etc/grml/fai/config/scripts/GRMLBASE/52-mdadm
    M etc/grml/fai/config/scripts/GRMLBASE/55-aoetools
    M etc/grml/fai/config/scripts/GRMLBASE/80-initramfs
    M etc/grml/fai/config/scripts/GRMLBASE/85-systemd
    M etc/grml/fai/config/scripts/GRMLBASE/90-update-alternatives
    M etc/grml/fai/config/scripts/GRMLBASE/91-update-pciids
    M etc/grml/fai/config/scripts/GRMLBASE/92-update-freshclam
    M etc/grml/fai/config/scripts/GRMLBASE/95-package-information
    M etc/grml/fai/config/scripts/GRMLBASE/96-apt-listbugs
    M etc/grml/fai/config/scripts/GRMLBASE/97-apt-listchanges
    M etc/grml/fai/config/scripts/GRMLBASE/98-clean-chroot
    M etc/grml/fai/config/scripts/GRMLBASE/99-finish-grml-build
    M etc/grml/fai/config/scripts/GRML_SMALL/90-update-alternatives
    M etc/grml/fai/config/scripts/GRML_SMALL/98-clean-chroot
    M etc/grml/fai/config/scripts/LATEX/98-clean-chroot
    M etc/grml/fai/config/scripts/RELEASE/98-clean-chroot
    M etc/grml/fai/config/scripts/RELEASE/99-update-wallpaper
    M etc/grml/fai/config/scripts/REMOVE_DOCS/98-clean-chroot

  Log Message:
  -----------
  scripts: fix shellcheck issues


Compare: https://github.com/grml/grml-live/compare/596da04fee9d...fe3eef989116

To unsubscribe from these emails, change your notification settings at https://github.com/grml/grml-live/settings/notifications


More information about the Git-commits mailing list