[Git-commits] [grml/grml-live] 6652ee: GHA: setup shellcheck

Tue Nov 26 18:02:46 CET 2024

  Branch: refs/heads/shellcheck
  Home:   https://github.com/grml/grml-live
  Commit: 6652ee215e0ce100671916b71ee991dbb3aa5c23
      https://github.com/grml/grml-live/commit/6652ee215e0ce100671916b71ee991dbb3aa5c23
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    A .github/workflows/pr-review.yml

  Log Message:
  -----------
  GHA: setup shellcheck

  Commit: d332387177cecab0131d856a596a1a845877ed64
      https://github.com/grml/grml-live/commit/d332387177cecab0131d856a596a1a845877ed64
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix quoting issues

  Commit: 61511d51588252820bf881ec98fa2b8be6b9c89a
      https://github.com/grml/grml-live/commit/61511d51588252820bf881ec98fa2b8be6b9c89a
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: annotate NOCOLORS usage

Used by init-functions. Until we replace that, add this annotation.

  Commit: 5a3ceb151155e9a8cfe0b5766348ebb43a2b9267
      https://github.com/grml/grml-live/commit/5a3ceb151155e9a8cfe0b5766348ebb43a2b9267
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: concat $@ correctly

  Commit: b0ae975a1b2a74b39214868f1b6b59b0d32a6b24
      https://github.com/grml/grml-live/commit/b0ae975a1b2a74b39214868f1b6b59b0d32a6b24
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2166

  Commit: 3a86cc3c6384307eade699ea870231379bc8ed27
      https://github.com/grml/grml-live/commit/3a86cc3c6384307eade699ea870231379bc8ed27
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: ignore init-functions,lsb-functions sources

  Commit: 2e261e5144933df5dacf6241bbc7c3a3b519c58f
      https://github.com/grml/grml-live/commit/2e261e5144933df5dacf6241bbc7c3a3b519c58f
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: do not trap SIGKILL

  Commit: 7e1cd3a963b08183f0bd415d0516ead99e767c9a
      https://github.com/grml/grml-live/commit/7e1cd3a963b08183f0bd415d0516ead99e767c9a
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: fix $? usage errors

  Commit: 6f64784a5c4bc1df12caafa8502c0f7bd20bf604
      https://github.com/grml/grml-live/commit/6f64784a5c4bc1df12caafa8502c0f7bd20bf604
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: stop exporting SHORT_NAME

AFAICT nothing uses SHORT_NAME outside of grml-live itself.

  Commit: cc8db1d319085a18cfde38443ba1d5c76a05cab2
      https://github.com/grml/grml-live/commit/cc8db1d319085a18cfde38443ba1d5c76a05cab2
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2155

Declare and assign separately to avoid masking return values.

  Commit: 9b712cb6ad75831b37062ccb01d70ee918b9ebd8
      https://github.com/grml/grml-live/commit/9b712cb6ad75831b37062ccb01d70ee918b9ebd8
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2162

read without -r will mangle backslashes. Not relevant here.

  Commit: 99602bf4eaf4e28d486b012765f08033a5f448ad
      https://github.com/grml/grml-live/commit/99602bf4eaf4e28d486b012765f08033a5f448ad
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: PIPESTATUS is an array

  Commit: c21d6a7cbc6cb230afb9ca02e343b55e8cece8ac
      https://github.com/grml/grml-live/commit/c21d6a7cbc6cb230afb9ca02e343b55e8cece8ac
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: ignore SC2164 in two places

  Commit: 08bd4c136d75bd29d5adcc0d80ac4ba477933e28
      https://github.com/grml/grml-live/commit/08bd4c136d75bd29d5adcc0d80ac4ba477933e28
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: use while/read instead of for find

  Commit: 99ff6e2dd2cdcd75d646e8161d8b2a406b9e66d5
      https://github.com/grml/grml-live/commit/99ff6e2dd2cdcd75d646e8161d8b2a406b9e66d5
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: remove dead extend_string_begin function

  Commit: 9b3ff7e9c1474d857a4c91cae1641aa908fdeecf
      https://github.com/grml/grml-live/commit/9b3ff7e9c1474d857a4c91cae1641aa908fdeecf
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix one SC2010 case

  Commit: f49eef6db31a3fc8a32181659259fcc0ccc08b00
      https://github.com/grml/grml-live/commit/f49eef6db31a3fc8a32181659259fcc0ccc08b00
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: ignore SC2010 in two cases

  Commit: 21a61852942f41c18d73b2056e222d34f3b26e3d
      https://github.com/grml/grml-live/commit/21a61852942f41c18d73b2056e222d34f3b26e3d
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: rewrite extend_string_end without expr

  Commit: 64ee2171bb9e361c32785cd8a50c441ffb4c93d4
      https://github.com/grml/grml-live/commit/64ee2171bb9e361c32785cd8a50c441ffb4c93d4
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2004

$/${} is unnecessary on arithmetic variables.

  Commit: 1c329fb13ee2034f75ce4eef07d743091e72f6b8
      https://github.com/grml/grml-live/commit/1c329fb13ee2034f75ce4eef07d743091e72f6b8
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2018/SC2019

  Commit: 40004bd2ce77eafb6e518a2445dd021e2b145897
      https://github.com/grml/grml-live/commit/40004bd2ce77eafb6e518a2445dd021e2b145897
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: write grmlmain.cfg in one go

  Commit: ad8802a4934caf9ff0d663be078e1cd0beb5dab0
      https://github.com/grml/grml-live/commit/ad8802a4934caf9ff0d663be078e1cd0beb5dab0
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: turn off two info messages

  Commit: 7715b3c9f38d4d1b0516f08ba0f32110330d6fff
      https://github.com/grml/grml-live/commit/7715b3c9f38d4d1b0516f08ba0f32110330d6fff
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M scripts/generate_netboot_package.sh
    M scripts/release_helper.sh

  Log Message:
  -----------
  scripts: fix quoting issues found by shellcheck

  Commit: 3ec0f6a6a491af4115e5d039add9c40bcfe366a0
      https://github.com/grml/grml-live/commit/3ec0f6a6a491af4115e5d039add9c40bcfe366a0
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M remaster/grml-live-remaster

  Log Message:
  -----------
  remaster: fix quoting issues found by shellcheck

  Commit: 9e49d7a10a0cb1d97d46f4216b319c8c6d0f4573
      https://github.com/grml/grml-live/commit/9e49d7a10a0cb1d97d46f4216b319c8c6d0f4573
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M etc/grml/fai/config/hooks/instsoft.GRMLBASE
    M etc/grml/fai/config/hooks/instsoft.ZFS
    M etc/grml/fai/config/hooks/savelog.LAST.source
    M etc/grml/fai/config/hooks/updatebase.GRMLBASE

  Log Message:
  -----------
  fai hooks: fix shellcheck issues

  Commit: 596da04fee9d044205b9cf3a75c4af6c8a0d33d4
      https://github.com/grml/grml-live/commit/596da04fee9d044205b9cf3a75c4af6c8a0d33d4
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-11-26 (Tue, 26 Nov 2024)

  Changed paths:
    M etc/grml/fai/config/scripts/DEBORPHAN/10-whitelist
    M etc/grml/fai/config/scripts/DEBORPHAN/98-clean-chroot
    M etc/grml/fai/config/scripts/GRMLBASE/01-packages
    M etc/grml/fai/config/scripts/GRMLBASE/02-run
    M etc/grml/fai/config/scripts/GRMLBASE/03-get-sources
    M etc/grml/fai/config/scripts/GRMLBASE/05-hostname
    M etc/grml/fai/config/scripts/GRMLBASE/15-initsetup
    M etc/grml/fai/config/scripts/GRMLBASE/16-depmod
    M etc/grml/fai/config/scripts/GRMLBASE/18-timesetup
    M etc/grml/fai/config/scripts/GRMLBASE/20-sudo
    M etc/grml/fai/config/scripts/GRMLBASE/21-usersetup
    M etc/grml/fai/config/scripts/GRMLBASE/25-locales
    M etc/grml/fai/config/scripts/GRMLBASE/30-fstab
    M etc/grml/fai/config/scripts/GRMLBASE/32-xorg
    M etc/grml/fai/config/scripts/GRMLBASE/33-aptsetup
    M etc/grml/fai/config/scripts/GRMLBASE/34-hosts
    M etc/grml/fai/config/scripts/GRMLBASE/38-udev
    M etc/grml/fai/config/scripts/GRMLBASE/39-modprobe
    M etc/grml/fai/config/scripts/GRMLBASE/45-grub-images
    M etc/grml/fai/config/scripts/GRMLBASE/46-grml-version
    M etc/grml/fai/config/scripts/GRMLBASE/47-update-wallpaper
    M etc/grml/fai/config/scripts/GRMLBASE/49-sshd
    M etc/grml/fai/config/scripts/GRMLBASE/50-lvm
    M etc/grml/fai/config/scripts/GRMLBASE/52-mdadm
    M etc/grml/fai/config/scripts/GRMLBASE/55-aoetools
    M etc/grml/fai/config/scripts/GRMLBASE/80-initramfs
    M etc/grml/fai/config/scripts/GRMLBASE/85-systemd
    M etc/grml/fai/config/scripts/GRMLBASE/90-update-alternatives
    M etc/grml/fai/config/scripts/GRMLBASE/91-update-pciids
    M etc/grml/fai/config/scripts/GRMLBASE/92-update-freshclam
    M etc/grml/fai/config/scripts/GRMLBASE/94-update-smart-drivedb
    M etc/grml/fai/config/scripts/GRMLBASE/95-package-information
    M etc/grml/fai/config/scripts/GRMLBASE/96-apt-listbugs
    M etc/grml/fai/config/scripts/GRMLBASE/97-apt-listchanges
    M etc/grml/fai/config/scripts/GRMLBASE/98-clean-chroot
    M etc/grml/fai/config/scripts/GRMLBASE/99-finish-grml-build
    M etc/grml/fai/config/scripts/GRML_SMALL/90-update-alternatives
    M etc/grml/fai/config/scripts/GRML_SMALL/98-clean-chroot
    M etc/grml/fai/config/scripts/LATEX/98-clean-chroot
    M etc/grml/fai/config/scripts/RELEASE/98-clean-chroot
    M etc/grml/fai/config/scripts/RELEASE/99-update-wallpaper
    M etc/grml/fai/config/scripts/REMOVE_DOCS/98-clean-chroot

  Log Message:
  -----------
  scripts: fix shellcheck issues

Compare: https://github.com/grml/grml-live/compare/fdeb7a4c8484...596da04fee9d

To unsubscribe from these emails, change your notification settings at https://github.com/grml/grml-live/settings/notifications