[issue1933] Zsh: modify activation of completion caching

[Thilo Six]

Thilo Six <tech at xk2c.de> added the comment:

Frank Terbeck schrieb/wrote:

> Hi Thilo.
> 
> I've looked at your patch this afternoon. 

Thank you for your time!


> A couple of things:
> 
> 1. I think your approach does more than we should: If someone
>    wishes to use a different setup from ours, they should be
>    able to disable our customizations. You're doing that, which
>    is good. But then, I don't think we need to check for any
>    predefined styles.

OK. Actually this was a prof of concept to myself. I trust your judgement.

> 2. My eyes tripped over the GRML_COMPLFOO names a couple of
>    times. This is purely subjective of course. But I've changed
>    the names to GRML_COMP_FOO which for some reason make my
>    eyes happier.

That is absolutely fine with me.

> 3. The newly introduced parameters lack documentation in
>    our setup's manual. ☺

I look into this.


> In any case: I've pushed a patch based on your code to our repository
> just now: ae3538fac9f47958ea9566b2b3818547684f8e76 — it addresses
> everything from my earlier enumeration. As always, thanks for your
> input and let us know if the code I pushed lacks something you need.

I have tested it and it does what i expect. So everything is nice.
Actually i have an other thing in mind. Since this is a completly different
issue i open a new bugreport for that.

> Frank Terbeck added the comment:
> 
> Correction. I had to rebase my branch onto some new changes in
> the repository, so the changes hash is actually:
> fd3a55f78b1e316727760a92dcd3f0759013549c

What did i wrong that you think you can throw a sha1 at me and know what to do
with it. grml  ;)


Thank you!



kind regards,

     Thilo


> ----------
> assignedto:  -> ft
> nosy: +ft
> status: unread -> fixed-in-git
> 
> _____________________________________
> GRML issue tracker <bts at bts.grml.org>
> <http://bts.grml.org/grml/issue1933>
> _____________________________________
>

----------
assignedto: ft
files: 0001-modify-activation-of-completion-caching.patch
messages: 5574, 5575, 5576, 5577
nosy: Xk2c, ft
priority: wish
status: fixed-in-git
title: Zsh: modify activation of completion caching
topic: has patch, zsh

_____________________________________
GRML issue tracker <bts at bts.grml.org>
<http://bts.grml.org/grml/issue1933>
_____________________________________