[issue1933] Zsh: modify activation of completion caching

[Frank Terbeck]

Frank Terbeck <ft at grml.org> added the comment:

Hi Thilo.

I've looked at your patch this afternoon. A couple of things:

1. I think your approach does more than we should: If someone
   wishes to use a different setup from ours, they should be
   able to disable our customizations. You're doing that, which
   is good. But then, I don't think we need to check for any
   predefined styles.

2. My eyes tripped over the GRML_COMPLFOO names a couple of
   times. This is purely subjective of course. But I've changed
   the names to GRML_COMP_FOO which for some reason make my
   eyes happier.

3. The newly introduced parameters lack documentation in
   our setup's manual. ☺

In any case: I've pushed a patch based on your code to our repository
just now: ae3538fac9f47958ea9566b2b3818547684f8e76 — it addresses
everything from my earlier enumeration. As always, thanks for your
input and let us know if the code I pushed lacks something you need.


Regards, Frank

----------
assignedto: ft
files: 0001-modify-activation-of-completion-caching.patch
messages: 5574, 5575
nosy: Xk2c, ft
priority: wish
status: fixed-in-git
title: Zsh: modify activation of completion caching
topic: has patch, zsh

_____________________________________
GRML issue tracker <bts at bts.grml.org>
<http://bts.grml.org/grml/issue1933>
_____________________________________