[Git-commits] [grml/grml-live] ea0c92: Fix logic around grml_sources handling no longer b...

Michael Prokop noreply at github.com
Thu Dec 19 02:20:28 CET 2024


  Branch: refs/heads/mika/sources-cleanup
  Home:   https://github.com/grml/grml-live
  Commit: ea0c92e25adb6913eb8d335b9905fba2b547e663
      https://github.com/grml/grml-live/commit/ea0c92e25adb6913eb8d335b9905fba2b547e663
  Author: Michael Prokop <mika at grml.org>
  Date:   2024-12-19 (Thu, 19 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  Fix logic around grml_sources handling no longer being bind-mounted

In commit 87524f9aa1efb2327f45feef9028461b683ffec5 we adjusted the
grml_sources handling, as bind mounts are not allowed in (unprivileged)
docker.

Now when running grml-live with SOURCES class enabled multiple times in
a row (e.g. via grml-live's `-b` or `-u` options), one ends up with the
$OUTPUT/grml_sources *and* $OUTPUT/grml_chroot/grml-live/grml_sources
directories. grml-live then complains:

  mv: cannot overwrite '$OUTPUT/grml_sources': Directory not empty
  rmdir: failed to remove '$OUTPUT/grml_chroot/grml-live': Directory not empty

As of commit 8b0a6fafc1003d1bac28c6c26c95bd1869d5d74d we generate a
source package tarball when using the SOURCES class, so one might want
to remove the "${OUTPUT}/grml_sources" directory anyway (similar to what
we're doing in commit 6486c8438f1bc0b508eaa9842ba1de5ffa3094fb in our CI
runs). But let's also fix the underlying logic and move grml_sources
around as expected.



To unsubscribe from these emails, change your notification settings at https://github.com/grml/grml-live/settings/notifications


More information about the Git-commits mailing list