[Git-commits] [grml/grml-live] 69b363: GHA: setup shellcheck

Chris Hofstaedtler noreply at github.com
Mon Dec 2 18:01:16 CET 2024 

  Branch: refs/heads/master
  Home:   https://github.com/grml/grml-live
  Commit: 69b36386c774dddf2057481db99ba2d8da0014da
      https://github.com/grml/grml-live/commit/69b36386c774dddf2057481db99ba2d8da0014da
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    A .github/workflows/pr-review.yml

  Log Message:
  -----------
  GHA: setup shellcheck


  Commit: a7fecfa5b6ad61e6bf8fff5e24fca8aba8d48937
      https://github.com/grml/grml-live/commit/a7fecfa5b6ad61e6bf8fff5e24fca8aba8d48937
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix quoting issues


  Commit: a999792f447e625e88585eb92ba519a372f3ef34
      https://github.com/grml/grml-live/commit/a999792f447e625e88585eb92ba519a372f3ef34
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: annotate NOCOLORS usage

Used by init-functions. Until we replace that, add this annotation.


  Commit: 939a5f4f0bd6ecbe01f3abd615d078ad6dcc7199
      https://github.com/grml/grml-live/commit/939a5f4f0bd6ecbe01f3abd615d078ad6dcc7199
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: concat $@ correctly


  Commit: 089cabd0fd6c9ed7b1d4619ee9ed43c1fe2c8f3e
      https://github.com/grml/grml-live/commit/089cabd0fd6c9ed7b1d4619ee9ed43c1fe2c8f3e
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2166


  Commit: b48460880b9b22a22ead144ffabbcae6492042ce
      https://github.com/grml/grml-live/commit/b48460880b9b22a22ead144ffabbcae6492042ce
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: ignore init-functions,lsb-functions sources


  Commit: abd83c6c065c9afc54b2723bb709d6b865b7898f
      https://github.com/grml/grml-live/commit/abd83c6c065c9afc54b2723bb709d6b865b7898f
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: do not trap SIGKILL


  Commit: 805dd42ed347a3f8922d53deaf205432ba6fe221
      https://github.com/grml/grml-live/commit/805dd42ed347a3f8922d53deaf205432ba6fe221
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: fix $? usage errors


  Commit: 581169c2ea1b97b0a684e0bff495530ba9a100b5
      https://github.com/grml/grml-live/commit/581169c2ea1b97b0a684e0bff495530ba9a100b5
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: stop exporting SHORT_NAME

AFAICT nothing uses SHORT_NAME outside of grml-live itself.


  Commit: 72f5e6090e9d8b037ce320d2247aa87861a658db
      https://github.com/grml/grml-live/commit/72f5e6090e9d8b037ce320d2247aa87861a658db
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2155

Declare and assign separately to avoid masking return values.


  Commit: ddc95527ff84603131f7d2edaaf4987d265e0a40
      https://github.com/grml/grml-live/commit/ddc95527ff84603131f7d2edaaf4987d265e0a40
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2162

read without -r will mangle backslashes. Not relevant here.


  Commit: 44112a591e59fe096775162931c69ef86916c959
      https://github.com/grml/grml-live/commit/44112a591e59fe096775162931c69ef86916c959
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: PIPESTATUS is an array


  Commit: 1eb31789fe37f60717093a9bb1bd28742e725bcb
      https://github.com/grml/grml-live/commit/1eb31789fe37f60717093a9bb1bd28742e725bcb
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: ignore SC2164 in two places


  Commit: 6e77072721c145852b3eb373258a49a04a6bbf02
      https://github.com/grml/grml-live/commit/6e77072721c145852b3eb373258a49a04a6bbf02
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: use while/read instead of for find


  Commit: d8501fdfea6f09f77251f1db49d86892223865b0
      https://github.com/grml/grml-live/commit/d8501fdfea6f09f77251f1db49d86892223865b0
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: remove dead extend_string_begin function


  Commit: 583b3db0401cb037ee4dd6f72a2df95a050b6816
      https://github.com/grml/grml-live/commit/583b3db0401cb037ee4dd6f72a2df95a050b6816
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix one SC2010 case


  Commit: 4694d45681716ffd51e685d9f3e0e6f77b6e058c
      https://github.com/grml/grml-live/commit/4694d45681716ffd51e685d9f3e0e6f77b6e058c
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: ignore SC2010 in two cases


  Commit: 3310807453e955c9ce1c89c059aca7d94b5a30c1
      https://github.com/grml/grml-live/commit/3310807453e955c9ce1c89c059aca7d94b5a30c1
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: rewrite extend_string_end without expr


  Commit: a8996f8b396775f4659a4880411c51c851cae5ba
      https://github.com/grml/grml-live/commit/a8996f8b396775f4659a4880411c51c851cae5ba
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2004

$/${} is unnecessary on arithmetic variables.


  Commit: 59bfaee2af72c95aced2e0f10dacec91934f7614
      https://github.com/grml/grml-live/commit/59bfaee2af72c95aced2e0f10dacec91934f7614
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: fix SC2018/SC2019


  Commit: af9fb68595ca69765a87dd27c3239e942f1f0fed
      https://github.com/grml/grml-live/commit/af9fb68595ca69765a87dd27c3239e942f1f0fed
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: write grmlmain.cfg in one go


  Commit: 5829fc85c62aa0947e4a75394b8f994d587a5fe9
      https://github.com/grml/grml-live/commit/5829fc85c62aa0947e4a75394b8f994d587a5fe9
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  shellcheck: grml-live: turn off two info messages


  Commit: df3eedbc046e57e86d046124611328a34f5a5301
      https://github.com/grml/grml-live/commit/df3eedbc046e57e86d046124611328a34f5a5301
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M scripts/generate_netboot_package.sh
    M scripts/release_helper.sh

  Log Message:
  -----------
  scripts: fix quoting issues found by shellcheck


  Commit: 9557a9da8c906e508a6ef35eaa5c79549bc3a9e6
      https://github.com/grml/grml-live/commit/9557a9da8c906e508a6ef35eaa5c79549bc3a9e6
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M remaster/grml-live-remaster

  Log Message:
  -----------
  remaster: fix quoting issues found by shellcheck


  Commit: 088dc5d96c11514fb05beb13fde6b6cf3254571f
      https://github.com/grml/grml-live/commit/088dc5d96c11514fb05beb13fde6b6cf3254571f
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M etc/grml/fai/config/hooks/instsoft.GRMLBASE
    M etc/grml/fai/config/hooks/instsoft.ZFS
    M etc/grml/fai/config/hooks/savelog.LAST.source
    M etc/grml/fai/config/hooks/updatebase.GRMLBASE

  Log Message:
  -----------
  fai hooks: fix shellcheck issues


  Commit: 5eb2286046098c77cf43d45d18e023eda2aa4c9c
      https://github.com/grml/grml-live/commit/5eb2286046098c77cf43d45d18e023eda2aa4c9c
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M etc/grml/fai/config/scripts/DEBORPHAN/10-whitelist
    M etc/grml/fai/config/scripts/DEBORPHAN/98-clean-chroot
    M etc/grml/fai/config/scripts/GRMLBASE/01-packages
    M etc/grml/fai/config/scripts/GRMLBASE/02-run
    M etc/grml/fai/config/scripts/GRMLBASE/03-get-sources
    M etc/grml/fai/config/scripts/GRMLBASE/05-hostname
    M etc/grml/fai/config/scripts/GRMLBASE/15-initsetup
    M etc/grml/fai/config/scripts/GRMLBASE/16-depmod
    M etc/grml/fai/config/scripts/GRMLBASE/18-timesetup
    M etc/grml/fai/config/scripts/GRMLBASE/20-sudo
    M etc/grml/fai/config/scripts/GRMLBASE/21-usersetup
    M etc/grml/fai/config/scripts/GRMLBASE/25-locales
    M etc/grml/fai/config/scripts/GRMLBASE/30-fstab
    M etc/grml/fai/config/scripts/GRMLBASE/32-xorg
    M etc/grml/fai/config/scripts/GRMLBASE/33-aptsetup
    M etc/grml/fai/config/scripts/GRMLBASE/34-hosts
    M etc/grml/fai/config/scripts/GRMLBASE/38-udev
    M etc/grml/fai/config/scripts/GRMLBASE/39-modprobe
    M etc/grml/fai/config/scripts/GRMLBASE/45-grub-images
    M etc/grml/fai/config/scripts/GRMLBASE/46-grml-version
    M etc/grml/fai/config/scripts/GRMLBASE/47-update-wallpaper
    M etc/grml/fai/config/scripts/GRMLBASE/49-sshd
    M etc/grml/fai/config/scripts/GRMLBASE/50-lvm
    M etc/grml/fai/config/scripts/GRMLBASE/52-mdadm
    M etc/grml/fai/config/scripts/GRMLBASE/55-aoetools
    M etc/grml/fai/config/scripts/GRMLBASE/80-initramfs
    M etc/grml/fai/config/scripts/GRMLBASE/85-systemd
    M etc/grml/fai/config/scripts/GRMLBASE/90-update-alternatives
    M etc/grml/fai/config/scripts/GRMLBASE/91-update-pciids
    M etc/grml/fai/config/scripts/GRMLBASE/92-update-freshclam
    M etc/grml/fai/config/scripts/GRMLBASE/95-package-information
    M etc/grml/fai/config/scripts/GRMLBASE/96-apt-listbugs
    M etc/grml/fai/config/scripts/GRMLBASE/97-apt-listchanges
    M etc/grml/fai/config/scripts/GRMLBASE/98-clean-chroot
    M etc/grml/fai/config/scripts/GRMLBASE/99-finish-grml-build
    M etc/grml/fai/config/scripts/GRML_SMALL/90-update-alternatives
    M etc/grml/fai/config/scripts/GRML_SMALL/98-clean-chroot
    M etc/grml/fai/config/scripts/LATEX/98-clean-chroot
    M etc/grml/fai/config/scripts/RELEASE/98-clean-chroot
    M etc/grml/fai/config/scripts/RELEASE/99-update-wallpaper
    M etc/grml/fai/config/scripts/REMOVE_DOCS/98-clean-chroot

  Log Message:
  -----------
  scripts: fix shellcheck issues


  Commit: 8253e80a5846ec58d049d2f35843407008045e9a
      https://github.com/grml/grml-live/commit/8253e80a5846ec58d049d2f35843407008045e9a
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: stop manipulating CWD


  Commit: fcbbf6ae39a6c438de013af602baf1a2a7791afa
      https://github.com/grml/grml-live/commit/fcbbf6ae39a6c438de013af602baf1a2a7791afa
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M grml-live

  Log Message:
  -----------
  grml-live: introduce hasclass helper function


  Commit: e50e0a8bc0df361edbca83507e8a7f40ea579b1f
      https://github.com/grml/grml-live/commit/e50e0a8bc0df361edbca83507e8a7f40ea579b1f
  Author: Chris Hofstaedtler <zeha at users.noreply.github.com>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    A .github/workflows/pr-review.yml
    M etc/grml/fai/config/hooks/instsoft.GRMLBASE
    M etc/grml/fai/config/hooks/instsoft.ZFS
    M etc/grml/fai/config/hooks/savelog.LAST.source
    M etc/grml/fai/config/hooks/updatebase.GRMLBASE
    M etc/grml/fai/config/scripts/DEBORPHAN/10-whitelist
    M etc/grml/fai/config/scripts/DEBORPHAN/98-clean-chroot
    M etc/grml/fai/config/scripts/GRMLBASE/01-packages
    M etc/grml/fai/config/scripts/GRMLBASE/02-run
    M etc/grml/fai/config/scripts/GRMLBASE/03-get-sources
    M etc/grml/fai/config/scripts/GRMLBASE/05-hostname
    M etc/grml/fai/config/scripts/GRMLBASE/15-initsetup
    M etc/grml/fai/config/scripts/GRMLBASE/16-depmod
    M etc/grml/fai/config/scripts/GRMLBASE/18-timesetup
    M etc/grml/fai/config/scripts/GRMLBASE/20-sudo
    M etc/grml/fai/config/scripts/GRMLBASE/21-usersetup
    M etc/grml/fai/config/scripts/GRMLBASE/25-locales
    M etc/grml/fai/config/scripts/GRMLBASE/30-fstab
    M etc/grml/fai/config/scripts/GRMLBASE/32-xorg
    M etc/grml/fai/config/scripts/GRMLBASE/33-aptsetup
    M etc/grml/fai/config/scripts/GRMLBASE/34-hosts
    M etc/grml/fai/config/scripts/GRMLBASE/38-udev
    M etc/grml/fai/config/scripts/GRMLBASE/39-modprobe
    M etc/grml/fai/config/scripts/GRMLBASE/45-grub-images
    M etc/grml/fai/config/scripts/GRMLBASE/46-grml-version
    M etc/grml/fai/config/scripts/GRMLBASE/47-update-wallpaper
    M etc/grml/fai/config/scripts/GRMLBASE/49-sshd
    M etc/grml/fai/config/scripts/GRMLBASE/50-lvm
    M etc/grml/fai/config/scripts/GRMLBASE/52-mdadm
    M etc/grml/fai/config/scripts/GRMLBASE/55-aoetools
    M etc/grml/fai/config/scripts/GRMLBASE/80-initramfs
    M etc/grml/fai/config/scripts/GRMLBASE/85-systemd
    M etc/grml/fai/config/scripts/GRMLBASE/90-update-alternatives
    M etc/grml/fai/config/scripts/GRMLBASE/91-update-pciids
    M etc/grml/fai/config/scripts/GRMLBASE/92-update-freshclam
    M etc/grml/fai/config/scripts/GRMLBASE/95-package-information
    M etc/grml/fai/config/scripts/GRMLBASE/96-apt-listbugs
    M etc/grml/fai/config/scripts/GRMLBASE/97-apt-listchanges
    M etc/grml/fai/config/scripts/GRMLBASE/98-clean-chroot
    M etc/grml/fai/config/scripts/GRMLBASE/99-finish-grml-build
    M etc/grml/fai/config/scripts/GRML_SMALL/90-update-alternatives
    M etc/grml/fai/config/scripts/GRML_SMALL/98-clean-chroot
    M etc/grml/fai/config/scripts/LATEX/98-clean-chroot
    M etc/grml/fai/config/scripts/RELEASE/98-clean-chroot
    M etc/grml/fai/config/scripts/RELEASE/99-update-wallpaper
    M etc/grml/fai/config/scripts/REMOVE_DOCS/98-clean-chroot
    M grml-live
    M remaster/grml-live-remaster
    M scripts/generate_netboot_package.sh
    M scripts/release_helper.sh

  Log Message:
  -----------
  Merge pull request #189 from grml/shellcheck

Setup shellcheck and fix all issues


Compare: https://github.com/grml/grml-live/compare/23ae643fe9d9...e50e0a8bc0df

To unsubscribe from these emails, change your notification settings at https://github.com/grml/grml-live/settings/notifications

More information about the Git-commits mailing list