[Git-commits] [grml/grml-live] d1575f: Drop /etc/grml/fai/config/files/etc/lsb-base-loggi...

Michael Prokop noreply at github.com
Thu Feb 2 14:00:15 CET 2023


  Branch: refs/heads/master
  Home:   https://github.com/grml/grml-live
  Commit: d1575f1e7726c4cbdfa27bcff9ef973cdb6709e1
      https://github.com/grml/grml-live/commit/d1575f1e7726c4cbdfa27bcff9ef973cdb6709e1
  Author: Michael Prokop <mika at grml.org>
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
    M debian/grml-live.maintscript
    R etc/grml/fai/config/files/etc/lsb-base-logging.sh/GRMLBASE
    M etc/grml/fai/config/scripts/GRMLBASE/42-branding

  Log Message:
  -----------
  Drop /etc/grml/fai/config/files/etc/lsb-base-logging.sh/GRMLBASE

In lsb upstream (https://salsa.debian.org/debian/lsb.git) commit
c3632166b1 ("Hardcode ANSI escapes to replace tput in logging
functions") the "TPUT=/usr/bin/tput" definition got dropped. At the end
of the file /lib/lsb/init-functions (being part of sysvinit-utils
nowadays) it then sources /etc/lsb-base-logging.sh, iff the file exists.

Now that $TPUT is no longer defined, it's failing for us with:

| /etc/lsb-base-logging.sh: line 19: -S: command not found
| /etc/lsb-base-logging.sh: line 19: -S: command not found

It looks like the file /etc/lsb-base-logging.sh is no longer relevant
for Grml nowadays, especially with running on systemd (the file got
introduced back in 2011, git commit 00b607, and its last modification
dates back to 2012, see commit 9f40afc).

Unless we really have any special needs for deploying our own
/etc/lsb-base-logging.sh let's get rid of it. If we should ever
reintroduce it again, we definitely need to make sure we don't rely on
any specific upstream behavior though.

Closes: https://github.com/grml/grml-live/issues/125




More information about the Git-commits mailing list