[Git-commits] [grml/grml-hwinfo] 3d5366: sysdump: rework ignore list code and ignore furthe...

Michael Prokop noreply at github.com
Fri Mar 5 17:39:26 CET 2021


  Branch: refs/heads/master
  Home:   https://github.com/grml/grml-hwinfo
  Commit: 3d53667bbd60379625f120ed3b90a5097f1cb248
      https://github.com/grml/grml-hwinfo/commit/3d53667bbd60379625f120ed3b90a5097f1cb248
  Author: Michael Prokop <mika at grml.org>
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
    M sysdump

  Log Message:
  -----------
  sysdump: rework ignore list code and ignore further files

When getting towards /sys/kernel/tracing, the script is known to hang
at least at the following files:

* /sys/kernel/tracing/trace_pipe
* /sys/kernel/tracing/per_cpu/cpu[0-9]+/trace_pipe
* /sys/kernel/tracing/per_cpu/cpu[0-9]+/trace_pipe_raw
* /sys/kernel/tracing/per_cpu/cpu[0-9]+/snapshot_raw

So we need to extend the list of files to be ignored.

While at it, rework the checks and ignore a bunch of further files, that
can't be read, e.g. due to "Permission denied".

FTR, we sadly can't ignore "/sys/.*/uevent" files globally, as
there are a bunch of files that contain and also provide actual data.

Thanks: Darshaka Patirana for tracking down the /sys/kernel/tracing/* issue
Closes: grml/grml-hwinfo#3


  Commit: 9193fd5e8a11c5e93fcfe5ec47aa7c046b9ba8b3
      https://github.com/grml/grml-hwinfo/commit/9193fd5e8a11c5e93fcfe5ec47aa7c046b9ba8b3
  Author: Michael Prokop <mika at grml.org>
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
    M grml-hwinfo

  Log Message:
  -----------
  Provide information to user if sysdump might be hanging

Sometimes new files show up in the kernel and sysdump
might be hanging while reading them. To make this more
visible to the user and how to track this down, provide
information, if not running with -q/-quiet.

Related to https://github.com/grml/grml-hwinfo/issues/3


  Commit: 42ab70c32a767273425f2f4c95076e31d3f94eed
      https://github.com/grml/grml-hwinfo/commit/42ab70c32a767273425f2f4c95076e31d3f94eed
  Author: Michael Prokop <mika at grml.org>
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
    M grml-hwinfo

  Log Message:
  -----------
  Log 'ip route show table' errors to corresponding error file

We are iterating over the defined tables in /etc/iproute2/rt_tables,
though for tables that don't exist, ip reports an ugly error message,
that's a bit confusing during execution within grml-hwinfo:

| root at grml ~ # grep -v '^#' /etc/iproute2/rt_tables
| 255     local
| 254     main
| 253     default
| 0       unspec
| root at grml ~ # ip route show table 253
| Error: ipv4: FIB table does not exist.
| Dump terminated

Instead, store its error message to an according error file.


  Commit: 18075669c17b8dc94237df0a48b760a56decd12d
      https://github.com/grml/grml-hwinfo/commit/18075669c17b8dc94237df0a48b760a56decd12d
  Author: Michael Prokop <mika at grml.org>
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
    M grml-hwinfo

  Log Message:
  -----------
  Log efibootmgr errors to efibootmgr.error

On non-UEFI systems, we get an ugly error message:

| root at grml ~ # efibootmgr -v >/dev/null
| Could not parse device path: Invalid argument

Instead log stderr output to efibootmgr.error


Compare: https://github.com/grml/grml-hwinfo/compare/aba8e139aa77...18075669c17b


More information about the Git-commits mailing list