[Git-commits] [grml/grml2usb] d01d9d: Coding style: fix pep8 + flake8 issues

[Michael Prokop]

  Branch: refs/heads/mika/cleanup
  Home:   https://github.com/grml/grml2usb
  Commit: d01d9d8b10e50be452bb5b3c86f1db127fad09fc
      https://github.com/grml/grml2usb/commit/d01d9d8b10e50be452bb5b3c86f1db127fad09fc
  Author: Michael Prokop <mika at grml.org>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M grml2usb

  Log Message:
  -----------
  Coding style: fix pep8 + flake8 issues

Fix:

| W605 invalid escape sequence '\s'

by using re.compile(r'...') instead of re.compile("...")

Fix:

| E261 at least two spaces before inline comment

introduced in commit ed5b633be961ef6b3

Fix flake8 issues:

| grml2usb:409:5: F841 local variable 'e' is assigned to but never used
| grml2usb:557:34: W504 line break after binary operator
| grml2usb:559:34: W504 line break after binary operator
| grml2usb:737:37: W504 line break after binary operator
| grml2usb:1615:13: F841 local variable 'error' is assigned to but never used
| grml2usb:1641:9: F841 local variable 'error' is assigned to but never used
| grml2usb:1665:5: F841 local variable 'error' is assigned to but never used
| grml2usb:1826:30: W504 line break after binary operator
| grml2usb:1832:30: W504 line break after binary operator

The https://www.flake8rules.com/rules/W503.html vs
https://www.flake8rules.com/rules/W504.html is strange,
though let's use what black(1) (see https://github.com/psf/black)
uses.


  Commit: b1880026ee8d798cf69dcd77dbf753b84d1b8ca1
      https://github.com/grml/grml2usb/commit/b1880026ee8d798cf69dcd77dbf753b84d1b8ca1
  Author: Michael Prokop <mika at grml.org>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M grml2usb

  Log Message:
  -----------
  Coding style: execute black + isort and fix undefined 'path'

Avoid discussions around pep8, pylint etc, but instead
use what black(1) (see https://github.com/psf/black) provides.

Fix:

| grml2usb:299:39: F821 undefined name 'path'


  Commit: f1d1ce8f45bc1bf5b0d91dded10e53cba990b385
      https://github.com/grml/grml2usb/commit/f1d1ce8f45bc1bf5b0d91dded10e53cba990b385
  Author: Michael Prokop <mika at grml.org>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M Makefile
    M debian/control
    A setup.cfg

  Log Message:
  -----------
  codecheck: rely on flake8, isort + black during build time

Switch from pyflakes, pylint + pep8 to flake8, isort + black,
and include it in the default build target to get checks during
build time. Add relevant packages to Build-Depends.

Thanks: Florian Apolloner for the feedback


  Commit: 31853ed9993e7ce676a533ec270fd7ff91a272fe
      https://github.com/grml/grml2usb/commit/31853ed9993e7ce676a533ec270fd7ff91a272fe
  Author: Michael Prokop <mika at grml.org>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M debian/control

  Log Message:
  -----------
  Bump Standards-Version to 4.5.0


  Commit: c921dc11983b7746fed3eedb301183eb0124c647
      https://github.com/grml/grml2usb/commit/c921dc11983b7746fed3eedb301183eb0124c647
  Author: Michael Prokop <mika at grml.org>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M debian/control
    M debian/tests/control

  Log Message:
  -----------
  debian: execute `wrap-and-sort -a -t -s`

Let's get this properly sorted...


  Commit: 1fa8aac195e43574b2704b2a11b78295896b0dd3
      https://github.com/grml/grml2usb/commit/1fa8aac195e43574b2704b2a11b78295896b0dd3
  Author: Michael Prokop <mika at grml.org>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M debian/tests/control
    R debian/tests/smoke-grml2usb-py2

  Log Message:
  -----------
  autopkgtests: drop python2 support and depend on python3 only

The smoke-grml2usb-py3 test was referring to python2.
python2 is no longer supported within Debian, let's drop
support for it.

Closes: #936663


Compare: https://github.com/grml/grml2usb/compare/d01d9d8b10e5%5E...1fa8aac195e4