[Git-commits] [grml/grml2usb] 25c3bf: Fix Python 3 syntax warning (is vs ==)

Michael Prokop noreply at github.com
Thu Apr 2 11:39:22 CEST 2020


  Branch: refs/heads/master
  Home:   https://github.com/grml/grml2usb
  Commit: 25c3bf7f43e285c2a6ab997a44efd8d21a514207
      https://github.com/grml/grml2usb/commit/25c3bf7f43e285c2a6ab997a44efd8d21a514207
  Author: Tomáš Virtus <nechtom at gmail.com>
  Date:   2020-02-03 (Mon, 03 Feb 2020)

  Changed paths:
    M grml2usb

  Log Message:
  -----------
  Fix Python 3 syntax warning (is vs ==)

Fixes the following warning:

  ./grml2usb:1691: SyntaxWarning: "is" with a literal. Did you mean "=="?
    if mbrcode is "":


  Commit: ed5b633be961ef6b3651b1e4c7756538c032aa19
      https://github.com/grml/grml2usb/commit/ed5b633be961ef6b3651b1e4c7756538c032aa19
  Author: Tomáš Virtus <nechtom at gmail.com>
  Date:   2020-02-03 (Mon, 03 Feb 2020)

  Changed paths:
    M grml2usb

  Log Message:
  -----------
  Support more Syslinux module locations

The current hardcoded directory of Syslinux modules,
/usr/lib/syslinux/modules/bios/, does not exist on ArchLinux. Since
modules are copied with copy_if_exist(), the installer doesn't notify
user when Syslinux modules are missing on the host. Furthermore, when
modules in Grml image are incompatible with Syslinux binary on the host,
the bootloader fails to load graphical menu as described in this bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943878

  Undef symbol FAIL: x86_init_fpu
  Failed to load libcom32.c32
  Failed to load COM32 file vesamenu.c32
  boot:

This change makes grml2usb look for more possible locations on the host
and adds --syslinux-libs option to add another location.


  Commit: f0e3c9362fe714123e8090207b382ceec0a87416
      https://github.com/grml/grml2usb/commit/f0e3c9362fe714123e8090207b382ceec0a87416
  Author: Tomáš Virtus <nechtom at gmail.com>
  Date:   2020-02-03 (Mon, 03 Feb 2020)

  Changed paths:
    M grml2usb

  Log Message:
  -----------
  Fix duplicate Syslinux entries

Documentation of open()[1] says:

  Other common values ... and 'a' for appending (which on some Unix
  systems, means that all writes append to the end of the file
  regardless of the current seek position).

On my system (Linux 5.4), writes to a file opened as 'a+' go at the end.

[1] https://docs.python.org/3/library/functions.html#open


  Commit: 99ecee20af64ca803b69e6e7d3cb7f112dc9ee9a
      https://github.com/grml/grml2usb/commit/99ecee20af64ca803b69e6e7d3cb7f112dc9ee9a
  Author: Tomáš Virtus <nechtom at gmail.com>
  Date:   2020-02-19 (Wed, 19 Feb 2020)

  Changed paths:
    A mbr/.gitignore

  Log Message:
  -----------
  Add mbr/ output files to gitignore


  Commit: 480b9746fc91e73c929a0b70b58472ed5cce6f1b
      https://github.com/grml/grml2usb/commit/480b9746fc91e73c929a0b70b58472ed5cce6f1b
  Author: Tomáš Virtus <nechtom at gmail.com>
  Date:   2020-02-19 (Wed, 19 Feb 2020)

  Changed paths:
    M grml2usb

  Log Message:
  -----------
  Fix duplicate Syslinux entries (2)

Commit f0e3c936 changed open mode to "r+", but this mode does not create
missing files.

Revert open mode back to "a+" and add seek to beginning of the file.


  Commit: 7a5091a230c93ae5d7c4d873a10aad16eb949bb3
      https://github.com/grml/grml2usb/commit/7a5091a230c93ae5d7c4d873a10aad16eb949bb3
  Author: Michael Prokop <mika at grml.org>
  Date:   2020-03-04 (Wed, 04 Mar 2020)

  Changed paths:
    M grml2usb
    A mbr/.gitignore

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/pr/26'


Compare: https://github.com/grml/grml2usb/compare/ebda68e43625...7a5091a230c9


More information about the Git-commits mailing list