[Git-commits] [grml/grml2usb] 66679f: Port to py3k

Michael Prokop noreply at github.com
Tue Oct 15 14:58:23 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/grml/grml2usb
  Commit: 66679fa795c0ea62114466729be25191947e6c73
      https://github.com/grml/grml2usb/commit/66679fa795c0ea62114466729be25191947e6c73
  Author: Michael Prokop <mika at grml.org>
  Date:   2019-10-15 (Tue, 15 Oct 2019)

  Changed paths:
    M debian/control
    M grml2usb

  Log Message:
  -----------
  Port to py3k

Quoting from #936663:

Python2 becomes end-of-live upstream, and Debian aims to remove
Python2 from the distribution, as discussed in
https://lists.debian.org/debian-python/2019/07/msg00080.html

Closes: #936663


  Commit: 29d54d4a9505cf92bae9fc4ba24b6253bdadedc9
      https://github.com/grml/grml2usb/commit/29d54d4a9505cf92bae9fc4ba24b6253bdadedc9
  Author: Michael Prokop <mika at grml.org>
  Date:   2019-10-15 (Tue, 15 Oct 2019)

  Changed paths:
    M grml2usb

  Log Message:
  -----------
  Avoid subprocess.Popen with stdout/stderr=PIPE and wait() usage

Quoting from https://docs.python.org/2/library/subprocess.html#popen-objects:

| Popen.wait()
|   Wait for child process to terminate. Set and return returncode attribute.
|
|   Warning
|   This will deadlock when using stdout=PIPE and/or stderr=PIPE and the child
|   process generates enough output to a pipe such that it blocks waiting for the
|   OS pipe buffer to accept more data. Use communicate() to avoid that.

While modprobe isn't expected to ever output enough output to be
relevant, let's better be safe than sorry.

While at it fix typo (it's -> its)

Closes grml/grml2usb#21


  Commit: b70606ae1a4665e5067d9e5fc008b9b6706a93d5
      https://github.com/grml/grml2usb/commit/b70606ae1a4665e5067d9e5fc008b9b6706a93d5
  Author: Michael Prokop <mika at grml.org>
  Date:   2019-10-15 (Tue, 15 Oct 2019)

  Changed paths:
    M debian/control
    M grml2usb

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/pr/22'


  Commit: 8bd4b9174b4ab450fcde1298ed02c4e2e54c60a6
      https://github.com/grml/grml2usb/commit/8bd4b9174b4ab450fcde1298ed02c4e2e54c60a6
  Author: Michael Prokop <mika at grml.org>
  Date:   2019-10-15 (Tue, 15 Oct 2019)

  Changed paths:
    M grml2usb

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/pr/23'


Compare: https://github.com/grml/grml2usb/compare/dbbca970b287...8bd4b9174b4a


More information about the Git-commits mailing list