[Git-commits] [grml/grml-network] fdbb48: Refactoring netcardconfig according to 'shellcheck...

[Michael Prokop]

  Branch: refs/heads/master
  Home:   https://github.com/grml/grml-network
  Commit: fdbb486eb8db30a3e052f98375790c1c40a7317c
      https://github.com/grml/grml-network/commit/fdbb486eb8db30a3e052f98375790c1c40a7317c
  Author: Mykola Malkov <mmalkov at sipwise.com>
  Date:   2018-03-27 (Tue, 27 Mar 2018)

  Changed paths:
    M sbin/netcardconfig

  Log Message:
  -----------
  Refactoring netcardconfig according to 'shellcheck' recommendations

Used 'shellcheck' https://github.com/koalaman/shellcheck recommendations:
SC2088 Tilde does not expand in quotes.
SC2086 Double quote to prevent globbing and word splitting.
SC2166 Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
SC2034 foo appears unused. Verify it or export it.
SC2162 read without -r will mangle backslashes.
SC2196 egrep is non-standard and deprecated. Use grep -E instead.
SC2128 Expanding an array without an index only gives the first element.
SC2068 Double quote array expansions to avoid re-splitting elements.
SC2001 See if you can use ${variable//search/replace} instead.
SC2006 Use $(STATEMENT) instead of legacy `STATEMENT`
SC2144 -e doesn't work with globs. Use a for loop.


  Commit: c41a34b792b5605b89da1914f6dd366c0ac9cb45
      https://github.com/grml/grml-network/commit/c41a34b792b5605b89da1914f6dd366c0ac9cb45
  Author: Mykola Malkov <mmalkov at sipwise.com>
  Date:   2018-03-27 (Tue, 27 Mar 2018)

  Changed paths:
    M sbin/netcardconfig

  Log Message:
  -----------
  Add support of VLAN configuration


  Commit: 956aca8cbb34395a8d4baeee044ce93f245c4365
      https://github.com/grml/grml-network/commit/956aca8cbb34395a8d4baeee044ce93f245c4365
  Author: Mykola Malkov <mmalkov at sipwise.com>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M sbin/netcardconfig

  Log Message:
  -----------
  Refactoring netcardconfig according to 'shellcheck' recommendations

Used 'shellcheck' https://github.com/koalaman/shellcheck recommendations:
SC2088 Tilde does not expand in quotes.
SC2086 Double quote to prevent globbing and word splitting.
SC2166 Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
SC2034 foo appears unused. Verify it or export it.
SC2162 read without -r will mangle backslashes.
SC2196 egrep is non-standard and deprecated. Use grep -E instead.
SC2128 Expanding an array without an index only gives the first element.
SC2068 Double quote array expansions to avoid re-splitting elements.
SC2001 See if you can use ${variable//search/replace} instead.
SC2006 Use $(STATEMENT) instead of legacy `STATEMENT`
SC2144 -e doesn't work with globs. Use a for loop.


  Commit: 61fe774d67a3300c18804f54fc884202148252a5
      https://github.com/grml/grml-network/commit/61fe774d67a3300c18804f54fc884202148252a5
  Author: Mykola Malkov <mmalkov at sipwise.com>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M sbin/netcardconfig

  Log Message:
  -----------
  Merge branch 'shellcheck' of github.com:darkmind/grml-network into shellcheck


  Commit: 7e77bd634d3968abfbb61bc82901781d5b8d4ab0
      https://github.com/grml/grml-network/commit/7e77bd634d3968abfbb61bc82901781d5b8d4ab0
  Author: Mykola Malkov <mmalkov at sipwise.com>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M sbin/netcardconfig

  Log Message:
  -----------
  Fix default exit code of bailout

Exit code 0 if the funciton is called without arguments


  Commit: 597006195c1c3d6336fd71c36d27b605ea569f81
      https://github.com/grml/grml-network/commit/597006195c1c3d6336fd71c36d27b605ea569f81
  Author: Michael Prokop <mika at grml.org>
  Date:   2018-05-25 (Fri, 25 May 2018)

  Changed paths:
    M sbin/netcardconfig

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/pr/3'


  Commit: 9792465a8ddd55f49e8994d4abf0a78652992caf
      https://github.com/grml/grml-network/commit/9792465a8ddd55f49e8994d4abf0a78652992caf
  Author: Michael Prokop <mika at grml.org>
  Date:   2018-05-25 (Fri, 25 May 2018)

  Changed paths:
    M sbin/netcardconfig

  Log Message:
  -----------
  netcardconfig: switch from ifconfig to ip(8)

The output of ifconfig changed in recent versions, breaking
parsing the available interfaces. Use that as a good excuse
for switching from ifconfig to ip.

The 's/@.*//' is required to strip the '@ethX0' from the interface
names 'vlan42 at eth0', since in /sys/class/net/ only vlan42 exists
as such and not vlan42 at eth0.


  Commit: 0129d4078b03e9f0919ad24368c4e88189b9702c
      https://github.com/grml/grml-network/commit/0129d4078b03e9f0919ad24368c4e88189b9702c
  Author: Michael Prokop <mika at grml.org>
  Date:   2018-05-25 (Fri, 25 May 2018)

  Changed paths:
    M sbin/netcardconfig

  Log Message:
  -----------
  netcardconfig: default VLAN option to no and ensure 8021q module is loaded

Configuring VLAN is optional and usually not required, so default
to no.

Without the 8021q module being loaded it spills a warning
message, even though it works fine. This might be confusing
for the user though, so let's loaded ahead.


Compare: https://github.com/grml/grml-network/compare/1ab81a8c2479...0129d4078b03
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.