[Git-commits] [grml/grml-etc-core] af6508: Partly revert c0a2a4d again

Frank Terbeck ft at grml.org
Sat Dec 30 11:19:39 CET 2017


  Branch: refs/heads/master
  Home:   https://github.com/grml/grml-etc-core
  Commit: af65087851ed8d2f74bd025b5862f5222884da97
      https://github.com/grml/grml-etc-core/commit/af65087851ed8d2f74bd025b5862f5222884da97
  Author: Frank Terbeck <ft at grml.org>
  Date:   2017-12-30 (Sat, 30 Dec 2017)

  Changed paths:
    M etc/zsh/zshrc

  Log Message:
  -----------
  Partly revert c0a2a4d again

As it turns out, zsh has defaults on HISTSIZE and SAVEHIST. I have lost track
off zsh defaults a long time ago. This is a reason not to do this at all.
HISTSIZE's default is 30, SAVEHIST's default is 0. And the latter is a big
problem: No history will be saved anymore.

If someone wants different values for these two parameters, they can set them
in .zshrc.local. I am NOT working around this by comparing the actual value to
zsh's defaults.

The combined diff of c0a2a4d and this commit looks like this:

[snip]
--- a/etc/zsh/zshrc
+++ b/etc/zsh/zshrc
@@ -1582,7 +1582,7 @@ function command_not_found_handler () {
 # history

 #v#
-HISTFILE=${ZDOTDIR:-${HOME}}/.zsh_history
+HISTFILE=${HISTFILE:-${ZDOTDIR:-${HOME}}/.zsh_history}
 isgrmlcd && HISTSIZE=500  || HISTSIZE=5000
 isgrmlcd && SAVEHIST=1000 || SAVEHIST=10000 # useful for setopt append_history
[snap]

Closes: Github bugreport #64




More information about the Git-commits mailing list