[issue1351] etc/zsh/zshrc: make sll() do actually s.th. usefull

[Thilo Six]

Thilo Six <tech at xk2c.de> added the comment:

Frank Terbeck schrieb/wrote:

-- <snip> --
> The #f1# line needs to be located directly above the "sll() {" line,

check.

> I'd like this to be
> 
>     if ...; then

check.

-- <snip> --
> Also for consistency, "local -i RTN ..." and "local -a SEENINODES" here.

check.

-- <snip> --
> Also for consistency
> 
>     for i in ...; do

check.

Updated patch attached. It also fixes a bug in symlink loop detection.
I ran a complete test suite to make sure no regression is introduced.


> Other than that, this looks good to me.
> 
> Thanks for your work!

Thank you for your review!



kind regards,

     Thilo

----------
files: 0001-modified-sll-to-among-others-detect-symlink-loops-an.patch, 0001-patch-b_sll_updated.patch, test.sh
messages: 4955, 4956, 4957, 4958, 4959, 4960, 4961, 4962, 4969, 4970, 4971
nosy: Xk2c
priority: feature
status: chatting
title: etc/zsh/zshrc: make sll() do actually s.th. usefull

_____________________________________
GRML issue tracker <bts at bts.grml.org>
<http://bts.grml.org/grml/issue1351>
_____________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-patch-b_sll_updated.patch
Type: text/x-diff
Size: 3935 bytes
Desc: not available
URL: <http://ml.grml.org/pipermail/bugs-changes/attachments/20150524/1d04969c/attachment.patch>