[issue1284] check4progs() add option to operta in silent mode

Frank Terbeck bts at bts.grml.org
Sun Nov 17 15:44:01 CET 2013


Frank Terbeck <ft at grml.org> added the comment:

Thilo Six wrote:
[...]
> Thats it! It has been tested in bash (4.2.45) and zsh (5.0.2) and verified that
> it works as aspected.

Great!

[...]
> In script-functions there is one more change the discussed allready.
> I changed the vim modeline:
>
> -# vim:foldmethod=marker tw=80 ai expandtab shiftwidth=2 tabstop=8
> +# vim:foldmethod=marker tw=80 ai expandtab shiftwidth=2 tabstop=8 ft=sh
[...]

Since this is another unrelated change, I'd usually request two separate
patches. But since you're getting to learn git (and probably version
control as a whole) just now, I'll split them up manually. 

Actually, we could split this up even more, since the does two things:

    - Add the --silent etc. options
    - Switch from ‘which’ to looping over $PATH.

But then again I'm lazy, so lets not over-engineer this. ;)

For the record, I'll attach patches for the two commits, that I will
push in just a minute. If the patches are formatted like this (the git
format-patch utility helps with this) the integration work on our side
is minimal. ;)

Regards, Frank

----------
assignedto: ft
files: 0001-script-functions-Set-filetype-to-sh-with-vim.patch, 0002-check4progs-Change-testing-from-which-to-iterating-o.patch, check4progs.PATHloop, check4progs.PATHloop, script-functions, script-functions, script-functions, script-functions.patch
messages: 4670, 4671, 4672, 4673, 4674, 4675, 4676, 4677, 4678, 4679, 4682, 4683, 4684, 4685, 4686, 4687, 4688
nosy: Xk2c, ft
priority: wish
status: chatting
title: check4progs() add option to operta in silent mode

_____________________________________
GRML issue tracker <bts at bts.grml.org>
<http://bts.grml.org/grml/issue1284>
_____________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-script-functions-Set-filetype-to-sh-with-vim.patch
Type: text/x-diff
Size: 804 bytes
Desc: not available
URL: <http://ml.grml.org/pipermail/bugs-changes/attachments/20131117/3900e004/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-check4progs-Change-testing-from-which-to-iterating-o.patch
Type: text/x-diff
Size: 2358 bytes
Desc: not available
URL: <http://ml.grml.org/pipermail/bugs-changes/attachments/20131117/3900e004/attachment-0001.patch>


More information about the Bugs-changes mailing list