[issue1166] Patch for debnet (grml-network)

[Michael Prokop]

Michael Prokop <mika at grml.org> added the comment:

* John S. Skogtvedt wrote in grml's BTS on 20120511 / 14:32:

> I found the following problems when trying to use debnet on grml 2011.12
> on a virtual machine with Debian Squeeze installed on LVM.

> I booted using the options lvm debnet, expecting debnet to use the
> /etc/network/interfaces file from the LVM logical volume. Instead, it
> used the /etc/network/interfaces file from /dev/loop0, because that is
> listed earlier in /proc/partitions.

> In addition, I found the two following problems in debnet:
> * DEVICES="$DEVICES $(ls /dev/mapper/*)" is redundant, because LVM
> logical volumes are listed in /proc/partitions (but perhaps the line is
> needed for other cases?)
> * "pump -k >/dev/null 2>&1" causes the script to always exit, because
> pump is not installed, and the shebang line includes the -e option to sh.

> I've attached a patch which removes the two mentioned lines and causes
> the script to ignore all loop devices. I've tested it and it seems to
> work for me: the /etc/network/interfaces file is successfully copied
> from the LVM logical volume, and the network is brought up.

Excellent catch, thanks for the bugreport and your patch!

I'm not sure whether anyone is using /dev/mapper/* outside of LVM
(as there *are* usecases for that), so I decided to be safe and kept
the line mentioning /dev/mapper/. The rest got applied and pushed,
will be released soon.

Thanks!

regards,
-mika-

----------
files: debnet.patch
messages: 4347, 4349
nosy: jss
status: chatting
title: Patch for debnet (grml-network)

_____________________________________
GRML issue tracker <bts at bts.grml.org>
<http://bts.grml.org/grml/issue1166>
_____________________________________