[issue982] update/modernize zsh functions simple-extractor, smartcompress & ogg2mp3

Frank Terbeck bts at bts.grml.org
Mon May 9 22:21:15 CEST 2011


Frank Terbeck <ft at grml.org> added the comment:

Bernhard Tittelbach wrote:
> New submission from Bernhard Tittelbach <xro at realraum.at>:
>
> discovered that above mentionend functions are a bit outdated.
> ogg2mp3 doesn't work as advertised on my system, maybe lame changed behaviour ?
> the archive functions don't know about xz and the simple-extractor can generally
> use some overhowl.
>
> beside fixing the above, I rewrote simple-extractor so that:
> * it behaves consistently for all archive types (no more deleting of source file
> or not depending on archive type e.g. .gz vs .tar.gz)
> * it takes filepaths as well as URIs
> * it handles more archive types
> * it optionally deletes the source archive

I like the general tone of this one. Two things though: First, since
this is a substantial change - and although I didn't see anything fishy
in it - we're close to a release right now, so how well did you test
this? :-)

And second: Since you've extended the function's behaviour, could you
also update the manual in `doc/grmlzshrc.t2t' accordingly, please?

Regards, Frank

----------
assignedto: ft
files: ogg2mp3.zshrc.patch, simple-extractor.zshrc.patch
messages: 3745, 3746, 3747, 3768, 3769
nosy: btittelbach, ft
priority: feature
status: chatting
title: update/modernize zsh functions simple-extractor, smartcompress & ogg2mp3
topic: zsh

_____________________________________
GRML issue tracker <bts at bts.grml.org>
<http://bts.grml.org/grml/issue982>
_____________________________________


More information about the Bugs-changes mailing list