[issue843] grml-network issues (bashisms/dependency)

[Michael Prokop]

Michael Prokop <mika at grml.org> added the comment:

Thanks for your patches, Darsha. I didn't apply them as they are but decided to 
slightly adjust them:

* iptables shouldn't be a dependency but just a Recommends (it's not a strict 
dependency for all the scripts of grml-network)

* [ "$(id -ru)" -ne "0" ] isn't a string match, it would have to be != - but in 
agreement with Frank (our shell specialist) we decided to use "[ $(id -ru) -ne 
0 ]" instead

Fixed in git - upload will happen soon, thanks for your feedback and patches!

regards,
-mika-

----------
assignedto: mika
files: 0001-Fixed-bashisms-found-with-checkbashisms.patch, 0002-Added-iptables-dependency.patch, 0003-Fixed-testing-for-root.patch
messages: 3147, 3148, 3161
nosy: jkirk, mika
priority: bug
status: fixed-in-git
title: grml-network issues (bashisms/dependency)

_____________________________________
GRML issue tracker <bts at bts.grml.org>
<http://bts.grml.org/grml/issue843>
_____________________________________