[issue843] grml-network issues (bashisms/dependency)

[Darshaka Pathirana]

New submission from Darshaka Pathirana <dpat at syn-net.org>:

Package: grml-network
Version: 0.3.2
Severity: normal
Tags: patch

Hi!

grml-router fails when running in Ubuntu 9.10:

# grml-router
[: 17: !=: unexpected operator
/sbin/iptables not installed

So shouldn't grml-network depend on iptables (or at least recommend
it)?

I then cloned the git-repository and did:

% checkbashisms grml-network/sbin/*
script grml-network/sbin/grml-network is already a bash script; skipping
possible bashism in grml-network/sbin/grml-pptp-inode line 17 ($UID should be "$(id -ru)"):
if [ $UID != 0 ] ; then
possible bashism in grml-network/sbin/grml-pptp-inode line 49 (echo -e):
echo -e "#!/bin/sh\nLANG=C\nVPNSERVER=\"${VPNSERVER}\"\n" > /etc/init.d/pptp
script grml-network/sbin/grml-pptp-vcgraz does not appear to be a /bin/sh script; skipping
possible bashism in grml-network/sbin/grml-pptp-xdsl-students line 20 ($UID should be "$(id -ru)"):
if [ "$UID" != 0 ];  then
possible bashism in grml-network/sbin/grml-pptp-xdsl-students line 67 (echo -e):
echo -e "#!/bin/sh\nLANG=C\nVPNSERVER=\"${VPNSERVER}\"\n" > /etc/init.d/pptp
possible bashism in grml-network/sbin/grml-router line 14 ($UID should be "$(id -ru)"):
if [ $UID != 0 ]; then
script grml-network/sbin/grml-vnet is already a bash script; skipping
script grml-network/sbin/grml-vpnc-tugraz is already a bash script; skipping
script grml-network/sbin/modemlink is already a bash script; skipping
script grml-network/sbin/netcardconfig is already a bash script; skipping
script grml-network/sbin/scanmodem is already a bash script; skipping

I've attached some patches.

Greetings,
 - Darsha

-- System Information:
Debian Release: squeeze/sid
  APT prefers karmic-updates
  APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic')
Architecture: i386 (i686)

Kernel: Linux 2.6.31-20-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages grml-network depends on:
ii  dialog                   1.1-20080819-1  Displays user-friendly dialog boxe
ii  grml-etc-core            0.3.60          core ecetera files for the grml sy
ii  psmisc                   22.7-1          utilities that use the proc file s
ii  zsh                      4.3.10-5ubuntu1 A shell with lots of features

Versions of packages grml-network recommends:
ii  bridge-utils         1.4-5               Utilities for configuring the Linu
ii  nmap                 5.00-2              The Network Mapper
ii  pppoeconf            1.18ubuntu1         configures PPPoE/ADSL connections
ii  pptp-linux           1.7.2-3             Point-to-Point Tunneling Protocol 
ii  resolvconf           1.44ubuntu1         name server information handler
ii  uml-utilities        20070815-1.1ubuntu2 User-mode Linux (utility programs)
ii  vpnc                 0.5.3-1             Cisco-compatible VPN client
ii  wireless-tools       29-2ubuntu6         Tools for manipulating Linux Wirel
ii  wpasupplicant        0.6.9-3ubuntu1      client support for WPA and WPA2 (I
ii  wvdial               1.60.1+nmu2ubuntu1  PPP dialer with built-in intellige

Versions of packages grml-network suggests:
pn  isdnutils-base                <none>     (no description available)

-- no debconf information

----------
files: 0001-Fixed-bashisms-found-with-checkbashisms.patch, 0002-Added-iptables-dependency.patch
messages: 3147
nosy: jkirk
status: unread
title: grml-network issues (bashisms/dependency)

_____________________________________
GRML issue tracker <bts at bts.grml.org>
<http://bts.grml.org/grml/issue843>
_____________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fixed-bashisms-found-with-checkbashisms.patch
Type: text/x-diff
Size: 2009 bytes
Desc: not available
URL: <http://ml.grml.org/pipermail/bugs-changes/attachments/20100419/0d7d9b44/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Added-iptables-dependency.patch
Type: text/x-diff
Size: 889 bytes
Desc: not available
URL: <http://ml.grml.org/pipermail/bugs-changes/attachments/20100419/0d7d9b44/attachment-0001.patch>