[issue606] install-packages-{office, useful}: More compatibility to dash(1).

Frank Terbeck bts at bts.grml.org
Sat Jan 31 17:03:09 CET 2009


Frank Terbeck <ft at grml.org> added the comment:

Alexander Steinböck <bts at bts.grml.org>:
> -if [[ $1 == '-force' ]]; then
> +if [ $1 = '-force' ]; then

Nevermind my previous ACK...

[snip]
# foo.sh
[ $1 = -force ] && echo yay || echo nay
[snap]

% ./foo.sh
[: 1: =: unexpected operator
nay

So, NACK.
I'm all for more quoting.
Always quote variables in POSIX scripts unless you *really* know what
you're doing.

Regards, Frank

----------
files: 0001-install-packages-office-useful-Enhancing-dash-1.patch
messages: 1785, 1787, 1788, 1789, 1790
nosy: ft, mika, z3ttacht
priority: bug
status: chatting
title: install-packages-{office,useful}: More compatibility to dash(1).
topic: grml2hd

_____________________________________
GRML issue tracker <bts at bts.grml.org>
<http://bts.grml.org/grml/issue606>
_____________________________________


More information about the Bugs-changes mailing list