[issue616] grml-etc-core: Adding trainling spaces to various power completions.

[Alexander Steinböck]

Alexander Steinböck <z3ttacht at grml.org> added the comment:

* Frank Terbeck <bts at bts.grml.org>
> Well, I hope I'm not starting to nitpick too heavily.
You're a hard man to please. (o; But it's absolutely fine with me. In
fact, I appreciate your constructive criticism and all the effort
you're going through with your responses.
> But since I do like the way you're writing nice and lengthy commit
> messages, I think it's okay to see whether we can can them just
> right[tm]. :-)
Doing my best. But I'm aware of the fact that I can get rather complex
when writing in english. Therefore I'm really glad there's someone
reviewing the yackety-yak I produce.

> I don't like the wording. I know we're using 'power completion'
> elsewhere, too. But it's really just an expansion. There is *nothing*
> that's completed at all.
ACK.
> > Take '|& grep --color=auto ' for instance. Mind the trailing space.
> I guess I'd just drop this line altogether. It doesn't add much of
> value.
ACK.

> The patch itself looks fine. An updated patch with a cleaned up commit
> msg would be terrific, though. :)
Will do. But, before any further investigation, let's wait for mika's
point of view regarding the various expansions you've mentioned.

> However, I *seriously* don't know why the following are in the
> $abk[] hash at al. Where's the point in having those in addition to
> simple aliases?
> [...]
> The only reason I see would be to be able to expand aliases at will.
> Then again: are we adding new aliases to this list? Did we do it in
> the past, after we got this expansion? Can't compsys's _expand do
> something like that for us?
That's an interesting idea.

I'm not really using these expanѕion either -- exepct `e,.' for `print
-l' or a modified `mp' for `mplayer -vo xv -xy ' to specify width and
height -- and therefore I agree that several of these expansions are
rather questionable.
And a line such as
> >      'fori' 'for i ({..}) { }'
would IMHO be more useful when implemented as a widget.

But as I mentioned above, let's hear mika's point of view.

----------
files: 0001-zshrc-Add-a-trailing-space-for-several-power-comple.patch, 0002-zshrc-Disordered-argument-list-in-MPlayer-s-power-c.patch
messages: 1805, 1806, 1807, 1808, 1809
nosy: ft, mika, z3ttacht
priority: feature
status: chatting
title: grml-etc-core: Adding trainling spaces to various power completions.
topic: grml-etc-core, just ideas, zsh

_____________________________________
GRML issue tracker <bts at bts.grml.org>
<http://bts.grml.org/grml/issue616>
_____________________________________