[issue660] grml-policy needs a serious bit of love

[Michael Prokop]

Michael Prokop <mika at grml.org> added the comment:

* Frank Terbeck <bts at bts.grml.org> [20090407 13:56]:

> I've got some issues with grml-policy:
>   a) It's incomplete. No news here.

ACK

>   b) I don't see how -z is any clearer than -n in shell tests.

It's not the -z/-n itself but the else:

if foo ; then
   $short_part
else
   $long_part
fi

instead of:

if foo ; then
   $long_part
else
   $short_part
fi

>   c) We don't use mercurial anymore. Examples need to be about git.

ACK :)

regards,
-mika-

----------
messages: 2160, 2162
nosy: ft, mika
priority: bug
status: chatting
title: grml-policy needs a serious bit of love

_____________________________________
GRML issue tracker <bts at bts.grml.org>
<http://bts.grml.org/grml/issue660>
_____________________________________